Merged
Conversation
CMLabay
reviewed
Apr 10, 2025
CMLabay
left a comment
CMLabay
left a comment
There was a problem hiding this comment.
FormSwitch has different props in academy repo.
FormText has different props in academy repo.
RestaurantHeader has several differences in academy repo.
Box has several differences in academy repo.
A lot of the index files in academy have more in them than this repo
Maybe I am misunderstanding, but it seems like there are a lot of changes in Academy/exercises/react-native/20-building/01-solution that are not captured in this repo. I stopped at Design/Box, but to me it looks like we need to go back through everything and make sure each file are exactly the same.
DanDaManTran
deleted the
FE-184-native-app-migrate-improvements-from-academy-into-demo-app
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bitovi.atlassian.net/browse/FE-184
Checked and copied academy to demo. Most are already similar.